Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bvfilter bugs & fixes #51

Closed
rcedgar opened this issue Apr 24, 2020 · 3 comments
Closed

bvfilter bugs & fixes #51

rcedgar opened this issue Apr 24, 2020 · 3 comments
Labels
Bioinformatics Bioinformatics task bug Something isn't working

Comments

@rcedgar
Copy link
Collaborator

rcedgar commented Apr 24, 2020

I found and fixed some bugs in bvfilter. New binary posted here:

https://drive5.com/tmp/bvfilter.gz

The md5sum of the binary after gunzip should be bac9251f90e8bddb4f07e398a75ccb76.

Below is the bash script I used for testing. Note that the pipeline is single-threaded, uses bvfilter in memory-mapped mode, and uses bowtie2 in unpaired mode (-U) per Issue #50. I will post timing results from this test shortly, probably as an Issue (is there a better way?).

Notice that the -quiet option of bvfilter is required because otherwise it stupidly writes a copyright message to stdout and messes up the SAM header (this bug not yet fixed).

#!/bin/bash

SRR=SRR11454614

./bvfilter -load_bitvec cov.bv -output COV_BV

/usr/bin/time -o time.txt \
    | fastq-dump -Z $SRR \
    | ./bvfilter -quiet -search_bitvec /dev/stdin -threads 1 \
        -ref COV_BV \
        -wordlength 18 \
        -sharedmem \
        -output /dev/stdout \
    | bowtie2 -p 1 \
        -x cov1.id99.polyamasked \
        --very-sensitive-local \
        -U /dev/stdin \
    > hits.sam
@ababaian
Copy link
Owner

If you're posting data then maybe experiment notebook entry is the way to go

@rcedgar rcedgar added Bioinformatics Bioinformatics task bug Something isn't working labels Apr 24, 2020
@rcedgar
Copy link
Collaborator Author

rcedgar commented Apr 24, 2020

Ok. Note that I don't do automated notebooks, but can do PDFs. Should I post by doing a commit without a pull request? Either way, how are collaborators notified? With an Issue, it's prominent, but AFAIK it's not easy to see that there is a new notebook.

@ababaian
Copy link
Owner

You can commit it yes. I'll read it for sure, if there's a key piece of actionable data then we can open an issue regarding the action needed from that.

@rcedgar rcedgar closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bioinformatics Bioinformatics task bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants