Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDK build error from console lib #904

Closed
jmrossy opened this issue Aug 9, 2022 · 1 comment
Closed

Fix SDK build error from console lib #904

jmrossy opened this issue Aug 9, 2022 · 1 comment
Assignees

Comments

@jmrossy
Copy link
Contributor

jmrossy commented Aug 9, 2022

No description provided.

@jmrossy jmrossy self-assigned this Aug 9, 2022
@jmrossy
Copy link
Contributor Author

jmrossy commented Aug 9, 2022

Rossy

Today at 2:18 PM
I'm seeing a build error using the latest SDK coming from this use of an un-listed runtime dep here: https://github.com/abacus-network/abacus-monorepo/pull/859/files#diff-fcbd20c85364887c8a84ce55239f001ab6f6562dbb2106457c5893a99751390bR5
@asaoines Did you mean to import assert from console instead of using the abacus util's existing assert (i.e. utils.assert() )
Rossy

Today at 2:27 PM
Actually we use the console lib in two places. RetryProvider above and in utils/logging.ts: https://github.com/abacus-network/abacus-monorepo/blob/main/typescript/utils/src/logging.ts#L1

@Mattie some question as for Asa above. Did you mean to import from console? If so, then we need to explicitly include that as a runtime dep on utils. Though IMO we shouldn't add a dep for this, just logging to the globally available console should be fine 🙂
mattie

Today at 2:29 PM
I copied that import from @tkporter's version. I assumed that there was a reason the import was needed.
I am cool with removing if we know it won't change funcunality
Rossy

Today at 2:33 PM
@tkporter Is there an env we're using that doesn't have the default global console available? If not I don't think we need that lib
nambrot

Today at 2:35 PM
i wanna say this assert comes from the auto-import that VS code does for you and probably wasnt intentional
tkporter

Today at 2:35 PM
honestly forgot I added that so feel free to change as you see fit
I think I added it back when we were using console groups so I wanted the groupIndentation: 4, instead of the default of 2, but that's not used anymore so let's get rid of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant