Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination links are broken when default sorting is by name or price #279

Closed
dchekanov opened this issue Oct 19, 2015 · 5 comments
Closed
Assignees
Milestone

Comments

@dchekanov
Copy link

Details and how to reproduce:

  1. Log in into demo instance http://demo.abantecart.com/?s=demo_admin
  2. Change config_catalog_limit to 2
  3. Change config_product_default_sort_order to "Name A-Z"
  4. Go to http://demo.abantecart.com/index.php?rt=product/category&path=36
  5. Notice that products are sorted as expected
  6. Go the the second page via pagination link
  7. Notice the sorting order switches to "Default" and products are sorted accordingly

I guess you need to add prefixes for $sorting_href defined at https://github.com/abantecart/abantecart-src/blob/master/public_html/storefront/controller/pages/product/category.php#L120 just like it is done for $sort a few lines below that. Other listings could be affected as well (specials, manufacturer).

@abolabo
Copy link
Collaborator

abolabo commented Oct 27, 2015

fixed.
thanks to you for bug-report:)

@BasaraABC
Copy link
Collaborator

Bug is visible in Specials listing. Please fix

@abolabo
Copy link
Collaborator

abolabo commented Oct 27, 2015

fixed.

@BasaraABC
Copy link
Collaborator

Specials listing fixed.
Question: what is Default sort by option? Now if set in admin Sort Products as default by: Name A-Z and them select in listing Sort by: Default the sorting result is different
special_offers

@abolabo
Copy link
Collaborator

abolabo commented Oct 28, 2015

default means by "sort order" field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants