Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZCL_ABAPGIT_HASH, replace call of CALCULATE_HASH_FOR_RAW #3977

Closed
larshp opened this issue Oct 4, 2020 · 0 comments · Fixed by #3980
Closed

ZCL_ABAPGIT_HASH, replace call of CALCULATE_HASH_FOR_RAW #3977

larshp opened this issue Oct 4, 2020 · 0 comments · Fixed by #3980
Assignees
@g-back
Labels
good first issue Want to help out with something small? refactoring Change code without altering functionality

Comments

@larshp
Copy link
Member

larshp commented Oct 4, 2020 •
edited

replace call of function module CALCULATE_HASH_FOR_RAW with call to CL_ABAP_HMAC, it should exist in 702

DATA hash TYPE string.
DATA xstr TYPE xstring.
DATA input TYPE xstring VALUE 'AA11'.

cl_abap_hmac=>calculate_hmac_for_raw(
  EXPORTING
    if_key        = xstr
    if_data       = input
  IMPORTING
    ef_hmacstring = hash ).

WRITE / to_lower( hash ).

DATA(res) = zcl_abapgit_hash=>sha1_raw( input ).
WRITE / res.
@larshp larshp added refactoring Change code without altering functionality good first issue Want to help out with something small? labels Oct 4, 2020
@g-back g-back self-assigned this Oct 5, 2020
@larshp larshp mentioned this issue Oct 5, 2020
Closed
@g-back g-back mentioned this issue Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g-back g-back

Labels
good first issue Want to help out with something small? refactoring Change code without altering functionality
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ZCL_ABAPGIT_HASH: Change FM call to method call abapGit/abapGit
2 participants
@larshp @g-back