Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend check comments rule #1313

Open
FreHu opened this issue Sep 15, 2020 · 3 comments
Open

Extend check comments rule #1313

FreHu opened this issue Sep 15, 2020 · 3 comments
Labels
good first issue new rule

Comments

@FreHu
Copy link
Collaborator

FreHu commented Sep 15, 2020

" This is a comment

instead of

"This is a comment
@larshp
Copy link
Member

larshp commented Sep 15, 2020

yea, perhaps add to existing https://rules.abaplint.org/check_comments/ rule

@FreHu FreHu changed the title New rule: require space after comment Extend check comments rule Sep 15, 2020
@FreHu
Copy link
Collaborator Author

FreHu commented Sep 15, 2020

Maybe it would be better if you could specify forbidden comment patterns (quickfix removes entire comment), then you could also get rid of things like "use this source file for abab unit classes".

@larshp
Copy link
Member

larshp commented Sep 15, 2020

sounds good

@FreHu FreHu mentioned this issue Sep 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue new rule
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FreHu @larshp