Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playground: Monarch bugs / highlighting #554

Closed
FreHu opened this issue Sep 23, 2019 · 14 comments · Fixed by microsoft/monaco-languages#87
Closed

Playground: Monarch bugs / highlighting #554

FreHu opened this issue Sep 23, 2019 · 14 comments · Fixed by microsoft/monaco-languages#87
Assignees
@larshp

Comments

@FreHu
Copy link
Collaborator

FreHu commented Sep 23, 2019

These are gonna come up often:
image

Backticks look like they are invalid characters:
image
@larshp
Copy link
Member

larshp commented Sep 23, 2019

yea, lets collect the highlighting bugs here. I'm pretty sure there is also some issues regarding string templates, and nesting of string templates

@larshp larshp changed the title Monarch bugs Playground: Monarch bugs Sep 23, 2019
@larshp
Copy link
Member

larshp commented Sep 29, 2019 •
edited

highlighting, expected "FORM" to be highlighted

image

@FreHu
Copy link
Collaborator Author

FreHu commented Sep 30, 2019

Not a bug, but migh as well add stuff from the vscode plugin's language configuration. Note that the autoclosing pairs ( and [ have an extra trailing space which makes them more abap friendly.

larshp/vscode-abap#6

@larshp
Copy link
Member

larshp commented Oct 8, 2019 •
edited

SELECTION-SCREEN, TABBED, USER-COMMAND, SUBSCREEN

image

@larshp
Copy link
Member

larshp commented Oct 8, 2019

the "#",

image

@larshp
Copy link
Member

larshp commented Oct 9, 2019

pragmas,

image

@larshp
Copy link
Member

larshp commented Oct 16, 2019

"PARTIALLY IMPLEMENTED",

image

@larshp
Copy link
Member

larshp commented Oct 21, 2019

"AND", "@",

image

@larshp
Copy link
Member

larshp commented Oct 21, 2019

image

@larshp larshp changed the title Playground: Monarch bugs Playground: Monarch bugs / highlighting Dec 11, 2019
@larshp
Copy link
Member

larshp commented Dec 31, 2019 •
edited

image

image

@larshp larshp mentioned this issue Feb 20, 2020
Closed
@larshp larshp self-assigned this Mar 1, 2020
@larshp larshp mentioned this issue Mar 1, 2020
Merged
@larshp larshp closed this as completed Mar 2, 2020
@larshp larshp mentioned this issue Sep 8, 2020
Closed
@mbtools
Copy link
Collaborator

mbtools commented Sep 8, 2020

CONSTANT
LOG-POINT

image

@mbtools
Copy link
Collaborator

mbtools commented Sep 8, 2020

Some more for a later time...

  • Any term with hyphen like
  • AT... VALUE-REQUEST
  • DATA ... READ-ONLY
  • SELECTION-SCREEN COMMENT, PUSHBUTTON
  • RADIOBUTTON GROUP
  • MEMORY
  • SUBMIT ... VIA ... AND RETURN
  • IF ... CA ... CP ... BETWEEN (+other C/Nx operators)
  • IF ... NOT / OR / AND
  • SORT ... AS TEXT
  • TYPE-POOLS
  • METHOD ... PREFERRED PARAMETER
  • WRITE ... AS ICON

image

image

image

image

image

image

image

image

image

@larshp
Copy link
Member

larshp commented Sep 9, 2020

@mbtools thanks, can you help moving the 2 above issues to #1292

when semantic highlighting is part of LSP, most of it should be fixed, the highlighiting is currently not context based, it just looks at words

@larshp
Copy link
Member

larshp commented Sep 21, 2020

🎉 https://www.npmjs.com/package/monaco-editor 0.21.0 published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larshp larshp

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ABAP] Language fixes
3 participants
@FreHu @larshp @mbtools