Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: by default use the latest poetry version #62

Merged
merged 4 commits into from Feb 24, 2023
Merged

feat: by default use the latest poetry version #62

merged 4 commits into from Feb 24, 2023

Conversation

mammo0
Copy link
Contributor

@mammo0 mammo0 commented Feb 22, 2023

Hello,

with this PR the input variable poetry-version is no longer a required parameter.

By default the latest version of Poetry will be installed. If a user requires a specific version, it still can be specified with the poetry-version variable like before.

@abatilo abatilo changed the title by default use the latest poetry version feat!: by default use the latest poetry version Feb 23, 2023
Copy link
Owner

@abatilo abatilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! Can we move the if expression to be above the run? I believe this makes it feel more natural to read for other programmers.

action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@abatilo abatilo changed the title feat!: by default use the latest poetry version feat: by default use the latest poetry version Feb 23, 2023
@mammo0
Copy link
Contributor Author

mammo0 commented Feb 23, 2023

Can we move the if expression to be above the run?

Sure, no problem. But I think merging your suggestions didn't work as expected. Give me a moment to resolve the issue.

@abatilo
Copy link
Owner

abatilo commented Feb 23, 2023

Oh, you're totally right. The diff engine merged everything super strangely based on the comment suggestions. Thanks for fixing! Please re-request review when it's ready!

@mammo0 mammo0 requested a review from abatilo February 23, 2023 17:21
@mammo0
Copy link
Contributor Author

mammo0 commented Feb 23, 2023

Now it should work ;)

@abatilo abatilo merged commit 192395c into abatilo:master Feb 24, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mammo0 mammo0 deleted the default_use_latest_poetry_ver branch February 26, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants