Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw in ISequencer::next(N) when N > bufferSize #10

Closed
andrewkcorcoran opened this issue Jul 29, 2020 · 2 comments
Closed

Throw in ISequencer::next(N) when N > bufferSize #10

andrewkcorcoran opened this issue Jul 29, 2020 · 2 comments

Comments

@andrewkcorcoran
Copy link

Otherwise it's possible to get a deadlock where the producer is waiting for >N free slots which will never become free.

e.g.

https://github.com/LMAX-Exchange/disruptor/blob/master/src/main/java/com/lmax/disruptor/SingleProducerSequencer.java#L119
vs
https://github.com/Abc-Arbitrage/Disruptor-cpp/blob/master/Disruptor/SingleProducerSequencer.h#L89

oktal added a commit that referenced this issue Aug 11, 2020
@oktal
Copy link
Member

oktal commented Aug 11, 2020

Hello,

Thanks for raising the issue.

This has been fixed in 4194602

@oktal oktal closed this as completed Aug 11, 2020
@andrewkcorcoran
Copy link
Author

Hi thanks for the fix, however it looks like the fix is only for SingleProducerSequencer, the issue is also present in MultiProducerSequencer.

rosebible pushed a commit to rosebible/Disruptor-cpp that referenced this issue Mar 10, 2021
jsrdzhk pushed a commit to jsrdzhk/Disruptor-cpp that referenced this issue Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants