Eliminate overhead of std::function in EventPoller

[andrewkcorcoran]

https://github.com/Abc-Arbitrage/Disruptor-cpp/blob/master/Disruptor/EventPoller.h#L39 could be trivially refactored to take a forwarding reference as the eventHandler instead of a std::function. This would eliminate the potential for memory allocation when the std::function is constructed and the virtual call when the eventHandler is invoked.

[oktal]

Hello,

You are right, the eventHandler is not stored anywhere so we do not need a std::function there.

Do you want to submit a Pull Request ?

[andrewkcorcoran]

As it's such a simple change, if there's someone else who can submit the PR it would be a lot faster than waiting on me as the internal process I have to follow for external code contributions can take a while.

[slumber]

I can do this if you don't mind. @andrewkcorcoran

[andrewkcorcoran]

That's great Chris thanks.

…

On Wed, 16 Sep 2020, 6:39 pm Chris Sosnin, ***@***.***> wrote: I can do this if you don't mind. @andrewkcorcoran <https://github.com/andrewkcorcoran> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AL5LS3BZ3WJIBWF2NIPSNS3SGDEYJANCNFSM4ROWJHZA> .