Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect param on WhisperTimeStamped #33

Closed
juanchosaravia opened this issue May 30, 2023 · 4 comments
Closed

Incorrect param on WhisperTimeStamped #33

juanchosaravia opened this issue May 30, 2023 · 4 comments

Comments

@juanchosaravia
Copy link

Hi!
First of all, thanks for this awesome lib!! I love it!

I was testing the WhisperTimeStamped model and reading the documentation on the source code I found the option to set the 'segment_type' with these possible values
'options': ['Sentence', 'Word'],
image

but the code expects lowercase value 'word':
image

So the Options should indicate the value properly or change the code to accept 'Words'

Took me a while to realize why it was not working.

@abdeladim-s
Copy link
Owner

Hi @juanchosaravia,

You are welcome. Glad you found it useful :)

Yeah you are right, I think I will just make it small letters in all places. I will fix it quickly.

Thank you very much for taking the time to debug the code.

@abdeladim-s
Copy link
Owner

@juanchosaravia, Please give it a try now and let me know whether the problem is solved ?

@juanchosaravia
Copy link
Author

hey that was super quick! thanks!!
Yes looks perfect!

@abdeladim-s
Copy link
Owner

You are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants