Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Give access to the UIPanGestureRecognizer handler in Swifty360View #20

Closed
mikado2005 opened this issue Mar 25, 2022 · 2 comments

Comments

@mikado2005
Copy link
Contributor

mikado2005 commented Mar 25, 2022

Hi, great package! One easy-to-implement suggestion: In Swifty360View, create some access to the internal function, Swifty360CameraController.handlePan(). Right now, while Swifty360CameraController is an "open class", Swifty360View's cameraController var is private. Hence it doesn't matter that an app can create and modify a Swifty360CameraController, I don't see any way of then using it.

What I'm currently trying to do is control panning from touches made on a device whilst projecting the Swifty360View onto an AirPlay screen. I'm blocked from forwarding gestures made on the iOS device to Swifty360View, which only wants to accept gestures directly from its own view.

@abdullahselek
Copy link
Owner

Hi @mikado2005, good point please open a PR with your suggested changes and I'll take a look.

@mikado2005 mikado2005 changed the title Suggestion: Give access to the UIPanGestureRecognizer handler in Swity360View Suggestion: Give access to the UIPanGestureRecognizer handler in Swifty360View Mar 25, 2022
@abdullahselek
Copy link
Owner

Closing this as @mikado2005's PR has already been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants