Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Allow customization of the cache through ActiveSupport caching #48

Open
hallelujah opened this issue Apr 16, 2024 · 0 comments · May be fixed by #49
Open

[feature] Allow customization of the cache through ActiveSupport caching #48

hallelujah opened this issue Apr 16, 2024 · 0 comments · May be fixed by #49

Comments

@hallelujah
Copy link

hallelujah commented Apr 16, 2024 •
edited

This is a feature request. icon_cache is using a Hash by default

It would be great to:

  1. Set the cache as a config.cache_store in the Railtie
  2. Use a Rails null store or memory store by default

This will allow sharing the cache with multiple server processes. E.g. with Memcached
hallelujah added a commit to hallelujah/rails-heroicon that referenced this issue Apr 17, 2024
@hallelujah
[feature] Allow configuring caching
a89c33b 
As with Rails, this allows to configure the cache store
through `config.rails_heroicon_cache_store`

By default it is set to :memory_store.

Closes abeidahmed#48
@hallelujah hallelujah linked a pull request Apr 17, 2024 that will close this issue
Open
hallelujah added a commit to hallelujah/rails-heroicon that referenced this issue Apr 17, 2024
@hallelujah
[feature] Allow configuring caching
3a140a3 
As with Rails, this allows to configure the cache store
through `config.rails_heroicon_cache_store`

By default it is set to :memory_store.

Closes abeidahmed#48
@hallelujah hallelujah changed the title [feature] Allow usage of Rails.cache [feature] Allow customization of the cache through ActiveSupport caching Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feature] Allow configuring caching hallelujah/rails-heroicon
1 participant
@hallelujah