-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spread user-defined attributes in script and style tag in output #75
Comments
abelljs/abell-renderer#26 Needs to fixed before we work on this |
abelljs/abell-renderer#26 is fixed now. This is the file you would want to make changes in: |
Always wanted to contribute to Abell! Now that Hacktoberfest's here, I don't see any reason not to. I just forked the repo. Will look into the codebase and tell if I can take this. =) P.S. I'm not claiming the issue yet. If anyone is ready to work on it, you can assign it to them! |
Will start working on this from tomorrow |
Ohh I just realized this won't be possible for case like this: If there is condition like this: <AbellComponent>
<!-- ... -->
<script>
</script>
</AbellComponent> Comp2.abell <AbellComponent>
<!-- ... -->
<script type="module">
</script>
</AbellComponent> In this case, both the scripts will go into same file. According to Comp2.abell, this file now should be loaded as a module but according to Comp1.abell, this file is normal javascript file. This will add overall confusion on which behavior is given more priority so closing this issue for now. I'll reopen this if I could think of something. |
In components, User should be able to write,
and in output it will be rendered as,
The text was updated successfully, but these errors were encountered: