-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Already uploaded images(for edit purposes) #130
Conversation
Looks good - thanks for this PR and the demo, could you please also update the readme accordingly? |
NP @UncleDave, yes ofc I can update it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Can you please add some spaces if(..)
-> if (...)
to match our code style?
|
||
images = []; | ||
|
||
onRemoved(event){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
){
=> ) {
also :)
Also, I'm glad that you chose our lib for your first GitHub contribution :) |
On the subject of code style, as raised by @aberezkin, there is an |
@aberezkin thank you for your review&code style correction and I am also glad to help to improve this library because I found it really useful and simple. This is what Autoformat did to the component 2a82743. I will revert it if needed. Let me know what do you think? |
Fine by me. |
@UncleDave when this feature is going to be available for use in the package? Are you planning for pre-release so can use the development features and test them? smth like: 1.0.0-alpha.1 |
I have made that suggestion in #102, but I'm not the one who controls npm releases. |
Feature requested in #12 for edit purposes, also I added demo on the first page.
Please review this PR and let me know what do you think. I/We need this feature immediately in.
Thank you.