Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update something #249

Merged
merged 13 commits into from Nov 27, 2021
Merged

Update something #249

merged 13 commits into from Nov 27, 2021

Conversation

oooo26
Copy link
Collaborator

@oooo26 oooo26 commented Nov 27, 2021

  • delete unused parameters
  • pack specific parameters (add function: initial_setting & clear_setting)
  • pack restore_for_normal
  • restructure gs_path & gs support CV results output
  • rewrite screening (now use algorithmXXX.fit() and unlink with model_fit.h)
  • API update
  • simplify algorithm pointer (use algorithm_list_xxx uniformly)
  • move beta_size to Algorithm class

@Mamba413
Copy link
Collaborator

Have you checked the code via Pytest?

@oooo26
Copy link
Collaborator Author

oooo26 commented Nov 27, 2021

Yes, it has passed Pytest.

@Mamba413
Copy link
Collaborator

Yes, it has passed Pytest.

Have you changed anythings in pytest?

@oooo26
Copy link
Collaborator Author

oooo26 commented Nov 27, 2021

In PCA test, I find the sparse test actually give a dense matrix, so I change it to a coo_matrix there. Others are unchanged.

@Mamba413 Mamba413 merged commit ea4cd04 into abess-team:bugfix Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants