Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar not shown #91

Closed
rahulpoonia29 opened this issue May 9, 2024 · 8 comments · Fixed by #113
Closed

Navbar not shown #91

rahulpoonia29 opened this issue May 9, 2024 · 8 comments · Fixed by #113
Assignees
Labels

Comments

@rahulpoonia29
Copy link
Contributor

rahulpoonia29 commented May 9, 2024

The navbar is not shown initially when the theme is changed.
Scroll is needed to make it appear.

Screenshot 2024-05-09 210339

@rahulpoonia29
Copy link
Contributor Author

@abhay-raj19 Can you assign the issue under GSSoC'24

@abhay-raj19
Copy link
Owner

@rahulpoonia29 Now you can work on this !!

@rawani123
Copy link

can you assign this to me also?

@abhay-raj19
Copy link
Owner

it is showing prior to your PR

image

it was there and working fine .

@abhay-raj19 abhay-raj19 linked a pull request May 11, 2024 that will close this issue
@rahulpoonia29
Copy link
Contributor Author

rahulpoonia29 commented May 11, 2024

@abhay-raj19 The navbar is not shown for the start when theme is changed. You need to scroll to make it appear.

The scroll event must be triggered to decide weather the floating navbar is to be show or not (on mobile devices)

@abhay-raj19
Copy link
Owner

are you saying to fix it at scroll time also ?

@rahulpoonia29
Copy link
Contributor Author

rahulpoonia29 commented May 12, 2024

@abhay-raj19 Scroll down to more than 80vh and then change the theme. The navbar would not be visible. Then if you scroll it would become visible again. I have fixed that issue.

@abhay-raj19
Copy link
Owner

Okay Got it . @rahulpoonia29
Thanks For contributing 💙.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants