Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]: Small issues with Netgear example #294

Closed
3 tasks done
iandol opened this issue Feb 23, 2022 · 4 comments · Fixed by #293 or #321
Closed
3 tasks done

[Question]: Small issues with Netgear example #294

iandol opened this issue Feb 23, 2022 · 4 comments · Fixed by #293 or #321
Labels
QUESTION ❓ User asked about the working/usage of VidGear APIs. SOLVED 🏁 This issue/PR is resolved now. Goal Achieved!
Milestone

Comments

@iandol
Copy link
Contributor

iandol commented Feb 23, 2022

When going through https://abhitronix.github.io/vidgear/latest/help/netgear_ex/#using-netgear-with-webgear I came on some small issues with the code, @abhiTronix recommended they should be fixed; well he only mentioned the self. typo but I assume the missing import and the return value are also OK?

Acknowledgment

  • I have searched the issues for my issue and found nothing related or helpful.
  • I have read the FAQs.
  • I have read the Documentation.

Context

See closed issue #291. I opened a pull request fixing this here: #295

@iandol iandol added the QUESTION ❓ User asked about the working/usage of VidGear APIs. label Feb 23, 2022
@abhiTronix abhiTronix linked a pull request Feb 23, 2022 that will close this issue
6 tasks
@abhiTronix
Copy link
Owner

abhiTronix commented Feb 23, 2022

@iandol Thanks, but make sure next time not open to multiple PRs rather combine commits under one PR only. Also, I asked to make one change.

@abhiTronix abhiTronix added the WORK IN PROGRESS 🚧 currently been worked on. label Feb 23, 2022
@abhiTronix abhiTronix added this to the 0.2.6 milestone Feb 23, 2022
@abhiTronix abhiTronix added this to To do in VidGear v0.2.6 via automation Feb 23, 2022
@iandol
Copy link
Contributor Author

iandol commented Feb 23, 2022

OK, I'll roll changes into one in the future (other repos often prefer separate pulls to make a more explanatory commit log). I'm sorry but I can't see what change you've asked for in the pull request?

@abhiTronix
Copy link
Owner

abhiTronix commented Feb 24, 2022

@iandol see review on PR, you need to revert missing None.

@abhiTronix
Copy link
Owner

Successfully resolved and merged in commit 53ca17b

VidGear v0.2.6 automation moved this from To do to Done Feb 25, 2022
@abhiTronix abhiTronix added SOLVED 🏁 This issue/PR is resolved now. Goal Achieved! and removed WORK IN PROGRESS 🚧 currently been worked on. labels Feb 25, 2022
@abhiTronix abhiTronix linked a pull request Jul 5, 2022 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QUESTION ❓ User asked about the working/usage of VidGear APIs. SOLVED 🏁 This issue/PR is resolved now. Goal Achieved!
Projects
No open projects
2 participants