Asyncio: minor improvements and bugfixes. #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 🎨 Fixed naming conventions for recently added DXcam backend in ScreenGear. - 🚚 Relocated docs to better context. 📄 ScreenGear: Updated class and class parameters description.
#360) - 🐛 Fixed a bug caused by PyAV's raising error for `ndim==2` grayscale frames. - 🚑️ The API will now drop the third dimension if a `ndim==3` grayscale frames are detected. - ⚡️ Improved handling of the `format` parameter when constructing a `VideoFrame` from ndarray frames. - 💥 The API will raise a `ValueError` if unsupported shaped frames are detected.
- 🧑💻 Users can now alter video endpoint path from "/video" to any alphanumeric string. - 🚩 Added `custom_video_endpoint` optional string attribute for this purpose. - 🥅 Only alphanumeric string with no space in between are allowed as its value. - 🎨 Improved conditions logic to check if non-empty values are assigned to optional parameters.
…ute. - 🎨 Added example code, admonition, and necessary context.
- 💚 Updated `test_webgear_rtc_custom_stream_class` method. - ✨ Added `Custom_Grayscale_class` to produce `ndim==3` grayscale frames. - 🗑️ Removed unused imports.
…tribute. - 💚 Updated `test_webgear_options` method.
abhiTronix
added
BUG 🐛
This was
linked to
issues
Jul 7, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## testing #366 +/- ##
===========================================
- Coverage 94.03% 93.96% -0.08%
===========================================
Files 16 16
Lines 3136 3146 +10
===========================================
+ Hits 2949 2956 +7
- Misses 187 190 +3
☔ View full report in Codecov by Sentry. |
- 🚑️ Fixed bug in conditional logic which resulted in `custom_video_endpoint` attribute allowing non-alphanumeric values. - 🔊 Improved logging. CI: - ✅ Updated `test_webgear_routes` test to validate new custom endpoint. - ☂️ Updated tests to increase code coverage.
abhiTronix
added
SOLVED 🏁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
These PR include various improvements and fixes for asyncio packages namely Webgear and WebGear_RTC.
Requirements / Checklist
Related Issue
#360
#362
Context
This PR introduce bug fix related to
ndim==3grayscale frames in Webgear_RTC API, and added option to add custom video endpoint path to Webgear API, and other minor fixes.Types of changes