Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined name: 'self'. 'logger' defined on line 62 #88

Merged
merged 1 commit into from Jan 6, 2020
Merged

Undefined name: 'self'. 'logger' defined on line 62 #88

merged 1 commit into from Jan 6, 2020

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 5, 2020 •
edited by abhiTronix

Description

self is an undefined name in this context which will raise NameError.

logger defined on line 62.

Requirements / Checklist

Related Issue

#89

Context

self is an undefined name in this context which will raise NameError.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Screenshots (if available):

None

@cclauss
Undefined name: 'self'. 'logger' defined on line 62
f02c77c 
__self__ is an undefined name in this context with will raise NameError.

__logger__ defined on line 62
@abhiTronix abhiTronix self-assigned this Jan 6, 2020
@abhiTronix abhiTronix added BUG 🐛 Vidgear api's error, flaw or fault WORK IN PROGRESS 🚧 currently been worked on. PRIORITY : CRITICAL 🚨 Topmost Priority Issue labels Jan 6, 2020
@abhiTronix
Copy link
Owner

@cclauss Thank you for finding and fixing this bug. Also please make sure to go through contributing.md before making your next PR.

abhiTronix
abhiTronix approved these changes Jan 6, 2020
View reviewed changes
Copy link
Owner

@abhiTronix abhiTronix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Approved, Thanks.

@abhiTronix abhiTronix added this to the 0.1.7 milestone Jan 6, 2020
@abhiTronix abhiTronix merged commit eb6f424 into abhiTronix:development Jan 6, 2020
@abhiTronix abhiTronix added SOLVED 🏁 This issue/PR is resolved now. Goal Achieved! and removed WORK IN PROGRESS 🚧 currently been worked on. PRIORITY : CRITICAL 🚨 Topmost Priority Issue labels Jan 6, 2020
@cclauss cclauss deleted the patch-1 branch January 6, 2020 04:27
@abhiTronix abhiTronix mentioned this pull request Jan 6, 2020
Merged
7 tasks
@abhiTronix abhiTronix mentioned this pull request Apr 25, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhiTronix abhiTronix abhiTronix approved these changes

Assignees

@cclauss cclauss

@abhiTronix abhiTronix

Labels
BUG 🐛 Vidgear api's error, flaw or fault SOLVED 🏁 This issue/PR is resolved now. Goal Achieved!
Projects
None yet
Milestone
0.1.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cclauss @abhiTronix