Code Maintenance: Logging Updates #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new `logging handler` helper function. - Removed conflicting system-wide dictionary logging formatter. - Isolated each API & test loggers. - Removed PiGear from CLI completely due to hardware emulation limitation. - Other Minor fixes.
abhiTronix
added
ENHANCEMENT ⚡
Codecov Report
@@ Coverage Diff @@
## testing #95 +/- ##
===========================================
+ Coverage 75.67% 84.06% +8.39%
===========================================
Files 11 10 -1
Lines 1340 1205 -135
===========================================
- Hits 1014 1013 -1
+ Misses 326 192 -134
Continue to review full report at Codecov.
|
- defined logger for each API globally to avoid redundant clones. - limited Imported OpenCV API version check scope to helper.py only.
- Fixed incorrect logic for pulling frames - Added case for incorrect `color_space` value
abhiTronix
added
SOLVED 🏁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings various logging updates to fix faulty behavior that can conflict with other python libraries.
Keypoints
logging handlerhelper function.helper.pyonly.Requirements / Checklist
Related Issue
None(direct fix)
Context
The vidgear's custom color-logger can conflict with other libraries that breaks functionality. Similar behavior was encounter when
vidgearis used withuvicornpython library(More info: encode/uvicorn#410 (comment)), hence this PR aims at implementing separate isolated logger handler for vidgear and fixing other minor bugs.Types of changes
Screenshots (if available):
None