Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular package should be distributed as compiled JS, not TS #132

Open
ghost opened this issue Dec 30, 2019 · 2 comments
Open

Angular package should be distributed as compiled JS, not TS #132

ghost opened this issue Dec 30, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 30, 2019

Hi! I really appreciate that you've made an Angular version, but would it be possible to update your packaging process to run tsc --build on the Angular package before publishing it? I think it's fairly common to not recompile all dependencies in a Typescript workflow, so the decorator never actually gets compiled (at least with our workflow).

I'm not super familiar with Lerna, but I would guess it could simply be a matter of running a script from the inner package.json before completing the build.

Might also want to add main and types keys to the inner package.json as well, to help with resolutions.

If you'd prefer, I could try doing a PR for this, just let me know.

@alexisponcet
Copy link

I agree, that could be a really nice idea.

@alanhobbart
Copy link

Hi, is there any documentation on how to use the Angular version? I can’t find any

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants