Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xG timeline label should have xG value rather than minute of shot #32

Closed
Ryo-N7 opened this issue May 5, 2022 · 4 comments
Closed

xG timeline label should have xG value rather than minute of shot #32

Ryo-N7 opened this issue May 5, 2022 · 4 comments
Assignees

Comments

@Ryo-N7
Copy link
Collaborator

Ryo-N7 commented May 5, 2022

in plot_timeline() the label we have for shots/goals is the minute of that... which isn't really necessary due to the x-axis. The focus of this plot is on the xG so we should be labeling the xG value instead

@Ryo-N7 Ryo-N7 created this issue from a note in Version 0.2.0 (To do) May 5, 2022
@Ryo-N7 Ryo-N7 self-assigned this May 18, 2022
@Ryo-N7 Ryo-N7 moved this from To do to In progress in Version 0.2.0 May 18, 2022
@Ryo-N7
Copy link
Collaborator Author

Ryo-N7 commented May 18, 2022

hmm no, have to re-write a considerable amount of the code to restructure it to get it to generalize for any number of goals for either team

bit more work but it's got to be done...

@Ryo-N7 Ryo-N7 changed the title xG timeline label should have xG value rather than minute of shot xG timeline label should have xG value rather than minute of shot May 18, 2022
@Ryo-N7
Copy link
Collaborator Author

Ryo-N7 commented May 18, 2022

also handle 'own goal' cases

@Ryo-N7
Copy link
Collaborator Author

Ryo-N7 commented May 18, 2022

i'm also moving around the code so that the 'plot' element code like the title and themes stuff is all closer together and also happens right before the actual plot is made.

for some reason it was stuck at the top?

I've also consolidated a lot of the data pre-processing into one pipe instead of jumping around a myriad of steps and re-assigning it to the 'data' variable. much cleaner this way.

@Ryo-N7
Copy link
Collaborator Author

Ryo-N7 commented May 18, 2022

there's no need to split the geom_*() into separate data frames as you can just use group argument but i'll work on that in a separate issue?

@Ryo-N7 Ryo-N7 closed this as completed in 2276609 May 18, 2022
Version 0.2.0 automation moved this from In progress to Done May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant