Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify plot_pass() #64

Closed
harshkrishna17 opened this issue Jun 1, 2022 · 1 comment
Closed

Simplify plot_pass() #64

harshkrishna17 opened this issue Jun 1, 2022 · 1 comment
Projects
Version 0.2.0
Milestone
Finish release of...

Comments

@harshkrishna17
Copy link
Collaborator

plot_pass(), unlike all the other event data functions has too many parameters and only accepts the "statsbomb" data_type. We should simplify the function to make it more in line with the other functions and thus more intuitive for the users
@harshkrishna17
Copy link
Collaborator Author

plot_passflow() also only accepts the "statsbomb" data_type. That could be amended as well

@Ryo-N7 Ryo-N7 added this to To do in Version 0.2.0 via automation Jun 21, 2022
@Ryo-N7 Ryo-N7 moved this from To do to Done in Version 0.2.0 Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Version 0.2.0
Done
Milestone
Finish release of 0.2.0 ggshakeR
Development

No branches or pull requests
2 participants
@abhiamishra @harshkrishna17