Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use only base rules of airbnb(exclude react rules) #6

Closed
abhijithvijayan opened this issue Jul 2, 2020 · 3 comments
Closed

use only base rules of airbnb(exclude react rules) #6

abhijithvijayan opened this issue Jul 2, 2020 · 3 comments
Labels
breaking change effort: low around a day or less impact: high unblocks new usecases, substantial improvement to existing feature, fixes a major bug status: WIP Work in progress ... inputs welcome! ❤️ type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Comments

@abhijithvijayan
Copy link
Owner

As eslint-config-airbnb/base is deprecated in favour of eslint-config-airbnb-base, eslint-config-airbnb has to be removed and eslint-config-airbnb-base should be added from the dev-dependencies list

@abhijithvijayan abhijithvijayan added breaking change effort: low around a day or less impact: high unblocks new usecases, substantial improvement to existing feature, fixes a major bug status: WIP Work in progress ... inputs welcome! ❤️ type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change labels Jul 2, 2020
@abhijithvijayan
Copy link
Owner Author

abhijithvijayan commented Jul 2, 2020

The airbnb rules keep on messing with typescript rules.

In addition to eslint-config-airbnb-base, I am going with eslint-config-airbnb-typescript as it exposes overridden typescript rules

@abhijithvijayan
Copy link
Owner Author

abhijithvijayan commented Jul 2, 2020

I am not happy with using separate packages for javascript(eslint-config-airbnb-base) & typescript(eslint-config-airbnb-typescript) configurations

It might be better to publish a new package say @abhijithvijayan/eslint-config-airbnb that exposes

  • base.js (exposes rules of eslint-config-airbnb-base)
  • typescript.js (exposes eslint-config-airbnb-typescript/lib/shared.js)

So that

  • Base configuration can have custom rules and extend from @abhijithvijayan/eslint-config-airbnb/base
  • Typescript configuration can extend from Base and @abhijithvijayaneslint-config-airbnb/typescript

This way I can remove eslint-config-airbnb and just replace it with @abhijithvijayaneslint-config-airbnb and not worry about overrides, duplicate rules and other two other possible dev-dependencies

@abhijithvijayan
Copy link
Owner Author

Released in v2.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change effort: low around a day or less impact: high unblocks new usecases, substantial improvement to existing feature, fixes a major bug status: WIP Work in progress ... inputs welcome! ❤️ type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

No branches or pull requests

1 participant