Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: react + javascript branch #37

Closed
princesust opened this issue Jun 2, 2020 · 6 comments
Closed

Feat: react + javascript branch #37

princesust opened this issue Jun 2, 2020 · 6 comments
Labels
effort: low around a day or less good first issue Issue that doesn't require previous experience with this project. help wanted Issue with a clear description that the community can help with. impact: med minor perf improvements, fix broad userbase issues status: WIP Work in progress ... inputs welcome! ❤️ type: question or discussion Issue discussing or asking a question

Comments

@princesust
Copy link
Contributor

some people think typescript is extra overhead when you have a time constraint.
@abhijithvijayan abhijithvijayan added effort: low around a day or less good first issue Issue that doesn't require previous experience with this project. help wanted Issue with a clear description that the community can help with. impact: med minor perf improvements, fix broad userbase issues status: community assigned Assigned to a community member who has agreed to take this on type: question or discussion Issue discussing or asking a question labels Jun 2, 2020
@abhijithvijayan
Copy link
Owner

It doesn't require much effort.

@princesust
Copy link
Contributor Author

I already did it for myself. But a warning shows for core js. I resolved that issue by install core-js and make a change in .babelrc file. Not sure is that the correct procedure.

@abhijithvijayan
Copy link
Owner

I saw the core-js warning, didnt want to add another dependency and handle its updates and stuff.

It is a dependency of another dependency, unless the core team of the dependency that requires core-js changes it, we dont have to do anything and can ignore the warning.

Also, I will take care of the new branch, doesnt require much effort.

@princesust
Copy link
Contributor Author

Ok, I will push a new branch.

@abhijithvijayan abhijithvijayan changed the title Is it possible to make a branch with only react Feat: react + javascript branch Jun 6, 2020
@abhijithvijayan
Copy link
Owner

@princesust Checkout https://github.com/abhijithvijayan/web-extension-starter/tree/react-javascript branch

@abhijithvijayan abhijithvijayan added status: WIP Work in progress ... inputs welcome! ❤️ and removed status: community assigned Assigned to a community member who has agreed to take this on labels Jun 6, 2020
@abhijithvijayan
Copy link
Owner

Also pushed a fix to disable that core-js version warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: low around a day or less good first issue Issue that doesn't require previous experience with this project. help wanted Issue with a clear description that the community can help with. impact: med minor perf improvements, fix broad userbase issues status: WIP Work in progress ... inputs welcome! ❤️ type: question or discussion Issue discussing or asking a question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@princesust @abhijithvijayan