Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change member variable prefix in LoginActivity.java #13

Closed
abhijitparida opened this issue Oct 12, 2018 · 8 comments
Closed

Change member variable prefix in LoginActivity.java #13

abhijitparida opened this issue Oct 12, 2018 · 8 comments

Comments

@abhijitparida
Copy link
Owner

Prefix all member variables in LoginActivity.java with this. and remove the m prefix.

For example,

mContext

becomes

this.context

File location: /app/src/main/java/app/abhijit/iter/LoginActivity.java

If this is your first pull request, read this article: (https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github). Make sure all test cases pass before submitting your pull request.

Happy Hacktoberfest! 🔥

@jashasweejena
Copy link
Contributor

Hello! Can I work on this issue?

Thank you!

@abhijitparida
Copy link
Owner Author

Yeah sure!

@jashasweejena
Copy link
Contributor

bug

Facing this while doing a project sync. If only I add

google()

in the

allprojects {
repositories {
...
}
}

section in root level build.gradle it stops throwing that error. Should I add that?

Sorry for the inconvinience!

@abhijitparida
Copy link
Owner Author

Add it, but submit a different pull request for that.

@jashasweejena
Copy link
Contributor

Add it, but submit a different pull request for that.

Did do that. Can you please check?

@jashasweejena
Copy link
Contributor

Another problem I was facing was even though the app builds fine and installs on my device, yet still, I weirdly am not able to log in using my credentials. I tried uninstalling it and installing the one on play store and it works just fine. I guess some previous commit broke the login functionality. I did not touch anything else but just fix gradle sync.

Thank you!

@abhijitparida
Copy link
Owner Author

Did do that. Can you please check?

Merged 👍

Another problem I was facing was even though the app builds fine and installs on my device, yet still, I weirdly am not able to log in using my credentials. I tried uninstalling it and installing the one on play store and it works just fine. I guess some previous commit broke the login functionality. I did not touch anything else but just fix gradle sync.

Thank you!

Debug builds are configured not to make API requests to ITER servers. You can use any username (provided that it contains 10 digits) and the password must be password.

See: https://github.com/abhijitparida/bunk#contributing

@jashasweejena
Copy link
Contributor

Debug builds are configured not to make API requests to ITER servers. You can use any username (provided that it contains 10 digits) and the password must be password.

Ahh. Would get on working through this issue right away!
I'm sorry I did not read the contributing guidelines.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants