-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cy.react/cy.getreact fail to find component mounted with @cypress/react after 1st test #121
Comments
Hey @DaveHarlow Thanks for raising the concern with the maximum details possible. Appreciate it. I will spend some time over the weekend to dig deeper. |
Hello. I use version 2.3.7 |
Hi @chdg61 , i am really busy with day to day activities. But will definitely have a look in the upcoming weekend. Till then have a look in this example https://github.com/abhinaba-ghosh/cypress-react-selector/blob/master/component/components/ProductsList.spec.js |
OK. I see. I found out a problem. If I use resq$ without this wrapper then I get the same result. I tried running native resq$ by example: waitToLoadReact(2000).then(() => {
const component = resq$('MyComponent');
console.log('component', component);
}); As result, the first request has returned the correct data as ReactComponent. {
_nodes: e(0),
} |
Hey @chdg61 you have to mount and waitForReact before each test. Can you confirm the same? |
Yes. I call mount and waitForReact inside a test. Because I have different components and props for render for each test. I've played with resq$ library and found out that if I use this library without calling waitToLoadReact so it works correctly. So this library lets use root element as the second argument: After was looking at the code of your library I tried to replace |
If I will have free time I will try to make PR to fix it. Sure, If I can understand all code and context inside the library :) |
Hm... You are right. I didn't it. Now it's OK. I've added the environment and remove Thank you. I think that param of the environment must be required if a user uses @cypress/react |
@chdg61 I am glad that it worked. Thanks again for digging deep into it. @DaveHarlow I invested in your attached codebase and figured out the |
Steps to Reproduce:
Expected Results
Component found each time
Actual Results
Component is reliably found on the first test, always fails on the second and fails on the 3rd about 2/3rds of the time
I've added an example at https://github.com/DaveHarlow/cypress-react-selector-issue
The text was updated successfully, but these errors were encountered: