-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect error message? #4
Comments
Hi @gregfenton , thanks for the detailed error description. As a user you need to tell the react selector to wait for react to be loaded for below reason:
You will get a better understanding here: https://github.com/abhinaba-ghosh/cypress-react-selector#wait-for-application-to-be-ready-to-run-tests Also, have a look into the beforeAll method of these sample test: https://github.com/abhinaba-ghosh/cypress-react-selector/blob/master/cypress/integration/react-selector.spec.js Let me know if it helps. I am open to any suggestions. |
Correct, both those examples show |
@gregfenton That's a typo. Good catch! will be fixed in the next version. |
Typo is fixed in version V0.1.6 Closing the ticket. |
At line 22 of https://github.com/abhinaba-ghosh/cypress-react-selector/blob/master/index.js, the error message states:
but I believe that as a user of this plugin we are expected to run
cy.waitForReact()
? It looks likewaitToLoadReact()
is something being called "under the covers", not what a user of the plugin is expected to do?The text was updated successfully, but these errors were encountered: