-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement Request - Option to pass domain (fqdn) to build methods for message-id generation #50
Comments
Maybe I am missing something here, but I do not see a domain in the build methods. |
Ah, sorry! I should have mentioned it's about the message-id generation. The This makes the message-id like So what I am suggesting is, If we can accept an optional domain argument in the |
@abhishek-ram I've also raised a PR with suggested changes. Please check and share your thoughts :) |
it'd be nice if a domain can be an optional argument to the message & mdn
build
methods. Because thesocket.getfqdn()
returns the local IP.Please let me know what do you think. I'll be happy to raise a PR :)
Thanks!
The text was updated successfully, but these errors were encountered: