Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbes Billionaire Data Analysis #561

Closed
wants to merge 1 commit into from
Closed

Forbes Billionaire Data Analysis #561

wants to merge 1 commit into from

Conversation

pawaspy
Copy link
Contributor

@pawaspy pawaspy commented Jan 30, 2024

Pull Request for ML-Crate 💡

Issue Title:

  • Info about the related issue (Aim of the project) :
  • Name:
  • GitHub ID:
  • Idenitfy yourself:

Closes: #496

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

@github-actions GitHub Actions
Copy link

Our team will soon review your PR. Thanks @pawaspy :)

@abhisheks008
Copy link
Owner

Enhancing means updating/upgrading the existing project in terms of models, EDA and visualization of the existing dataset. You have created a separate project, that's not enhancement means. That's why I told you while taking the issue and I have also given you the link of the existing project for your reference. You need to work on with the existing project mentioned in the issue by me, upgrade with fine tuned models instead of the existing ones, try to conclude more points with your analysis skills and make the existing project more capable.

@pawaspy

@abhisheks008 abhisheks008 added the Requested Changes ⚙️ Some changes have been requested in this PR. label Jan 30, 2024
@pawaspy
Copy link
Contributor Author

pawaspy commented Jan 30, 2024 •
edited

@abhisheks008 So I have to make changes in the old jupyter file. But in that the dataset is changed and I have to add the models that I created in that jupyter file or do I have to create a new file

@abhisheks008
Copy link
Owner

@abhisheks008 So I have to make changes in the old jupyter file. But in that the dataset is changed and I have to add the models that I created in that jupyter file or do I have to create a new file

Use the existing project's dataset and make the changes to upgrade the existing models.

@abhisheks008
Copy link
Owner

Close due to inactivity.

@abhisheks008 abhisheks008 added wontfix ❌ This will not be worked on and removed Requested Changes ⚙️ Some changes have been requested in this PR. labels Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pawaspy pawaspy

Labels
wontfix ❌ This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forbes Billionaire Data Analysis
2 participants
@pawaspy @abhisheks008