Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aruco marker Detection #593

Closed

Conversation

jayeshrdeotalu
Copy link

@jayeshrdeotalu jayeshrdeotalu commented Mar 5, 2024

Pull Request for ML-Crate 馃挕

Issue Title: Aruco Marker Detection

  • Info about the related issue (Aim of the project) : To detect and read Aruco markers from the images
  • Name: Jayesh Deotalu
  • GitHub ID: jayeshrdeotalu
  • Idenitfy yourself: Contributor

Closes: #551 number that will be closed through this PR

Describe the add-ons or changes you've made 馃搩

I have collected images containing variety of aruco markers, using open cv's aruco marker library detected and read the markers within the images.

Give a clear description of what have you added or modifications made

Added code with dataset to detect and read Aruco markers.

Type of change 鈽戯笍

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 鈿欙笍

Describe how it has been tested
code has be tested with images of multiple size with different types of aruco markers, multiple aruco libraries are used to make code more robust.

Describe how have you verified the changes made
Changes are verified through unit testing.

Checklist: 鈽戯笍

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

github-actions bot commented Mar 5, 2024

Our team will soon review your PR. Thanks @jayeshrdeotalu :)

@abhisheks008
Copy link
Owner

Need to follow the project structure for this project. Update the project structure according to the requirement.

@abhisheks008 abhisheks008 added Requested Changes 鈿欙笍 Some changes have been requested in this PR. Contributors This label shows the contributions of the contributors other than the Open Source Programs. labels Mar 10, 2024
@jayeshrdeotalu
Copy link
Author

Done...

@jayeshrdeotalu
Copy link
Author

Could you please review my PR...

@abhisheks008
Copy link
Owner

Hi @jayeshrdeotalu sorry for replying late. It will be better if you just put the URL of dataset inside a README.md in the Dataset folder instead of putting all the datapoints individually.

@jayeshrdeotalu
Copy link
Author

Hello @abhisheks008 , the datapoints are collected from the google, so there is no specific source to the images.

@abhisheks008 abhisheks008 removed Requested Changes 鈿欙笍 Some changes have been requested in this PR. Contributors This label shows the contributions of the contributors other than the Open Source Programs. labels May 5, 2024
@jayeshrdeotalu
Copy link
Author

@abhisheks008 what happened...?

@abhisheks008
Copy link
Owner

Hi @jayeshrdeotalu this project repo will be participating SSOC. That's why removing all the pending tasks.

@jayeshrdeotalu
Copy link
Author

Ohh @abhisheks008 could you please tell me how to apply for SSOC?

@abhisheks008
Copy link
Owner

Here's the link, https://ssocseason3.devfolio.co/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aruco Marker Detection
2 participants