Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in Views/Task #39

Open
Mr-Lopes opened this issue Jul 26, 2018 · 3 comments
Open

Bugs in Views/Task #39

Mr-Lopes opened this issue Jul 26, 2018 · 3 comments

Comments

@Mr-Lopes
Copy link

Thank you for providing us a such great tool! In order to contribute, I found a couple of bugs in the views/task:

  1. the List's get method is not finding new elements (f.i. pageView.collection.get(prevSibId) ). By switching it by a filter on the array solved the issue ( f.i. pageView.collection.models.filter( (node) => node.id == prevSibId )[0].view );

  2. In the addNote method, the blur occurs after the new task is inserted, making the previous item to be set as empty. By positioning the blur before the new note fixed the problem.

Hope this helps!

@abhshkdz
Copy link
Owner

Thanks for trying it out @Mr-Lopes!

This is great, if you could send a quick PR with these fixes, I'm happy to merge them.

@Mr-Lopes
Copy link
Author

Awesome! I am happy to help! I am still working on making it work with multiple list simultaneously on the same page. Let me finish this upgrade first, then we can merge everything - if you are interested, of course.

@abhshkdz
Copy link
Owner

Yup, sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants