Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: VIRTUAL_HOST #47

Closed
ekkis opened this issue Mar 8, 2017 · 1 comment
Closed

Feature request: VIRTUAL_HOST #47

ekkis opened this issue Mar 8, 2017 · 1 comment

Comments

@ekkis
Copy link

ekkis commented Mar 8, 2017

if you look at https://github.com/BlackGlory/caddy-proxy you'll see that his package automatically regenerates a Caddyfile every time a new docker container gets fired. it looks at the environment variable, which contains the name we want the container to answer to, and maps appropriately.

it'd be great if this package could do this. reason: this package has 500+K pulls whilst BlackGlory's has 385 and gets no support. I can't make it work (I've already spent too much time trying) but I love the functionality

would it be difficult to do?

@abiosoft
Copy link
Owner

abiosoft commented Mar 8, 2017

The package you made reference to serves a different purpose to this as it is primarily using caddy as a reverse-proxy.

You are not tied to Caddyfile as you can specify yours by mounting one on /etc/Caddyfile.
And VIRTUAL_HOST to me is just an environment variable; which Caddyfile supports.

Feel free to re-open this and clarify to me if you think I got you wrong.

@abiosoft abiosoft closed this as completed Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants