Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lecture 8 - Connector function use "with open"? #21

Open
jrkkfst opened this issue Aug 15, 2019 · 2 comments
Open

Lecture 8 - Connector function use "with open"? #21

jrkkfst opened this issue Aug 15, 2019 · 2 comments

Comments

@jrkkfst
Copy link

jrkkfst commented Aug 15, 2019

I haven't looked in detail at the Connector function, but noted that after running it myself once the file didn't close immediately. Ie. I couldn't view it (it perhaps hadn't flushed the cache?)

My question is, would it be useful to open the log file in the Connector function using "with open" to always close the file, when needed?

Perhaps this has been considered and isn't necessary?

@Kristianuruplarsen
Copy link
Collaborator

This is a good suggestion, i have begun implementing it in elben10/ScrapingClass#1. If you want to contribute feel free.

@elben10
Copy link
Collaborator

elben10 commented Aug 15, 2019

Thanks for the suggestion. It is now implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants