Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The publisher should close the Ably connection when it has no trackables #170

Closed
KacperKluka opened this issue Feb 8, 2021 · 1 comment · Fixed by #778
Closed

The publisher should close the Ably connection when it has no trackables #170

KacperKluka opened this issue Feb 8, 2021 · 1 comment · Fixed by #778
Assignees
@KacperKluka
Labels
bug Something isn't working. It's clear that this does need to be fixed. enhancement New feature or improved functionality.

Comments

@KacperKluka
Copy link
Contributor

KacperKluka commented Feb 8, 2021 •
edited by sync-by-unito bot
Loading

When there are no trackables in the publisher then the Ably connection should be closed.

We can use the ably.close() and ably.connect() methods to accomplish that.
@KacperKluka
Copy link
Contributor Author

Closing and reopening the connection isn't a big problem itself. The real issue is that due to the fact that the Ably wrapper isn't very safe in terms of multithreading, with current implementation we might end up in a state where the connection is closed and it won't be reopened. Therefore, we should wait for #440 to be resolved before working on this issue.

@KacperKluka KacperKluka added enhancement New feature or improved functionality. and removed clarification-required labels Jan 12, 2022
@KacperKluka KacperKluka added bug Something isn't working. It's clear that this does need to be fixed. and removed enhancement New feature or improved functionality. labels Sep 12, 2022
This was linked to pull requests Oct 6, 2022
Start the Ably connection when the first trackable is added and stop it when the last trackable is removed #773
Closed
Start and stop the Ably connection manually depending on the number of added trackables #778
Merged
@KacperKluka KacperKluka mentioned this issue Jan 26, 2023
Closed
@JakubJankowski JakubJankowski mentioned this issue Feb 3, 2023
Closed
@sync-by-unito sync-by-unito bot added the enhancement New feature or improved functionality. label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KacperKluka KacperKluka

Labels
bug Something isn't working. It's clear that this does need to be fixed. enhancement New feature or improved functionality.
Milestone
No milestone
2 participants
@QuintinWillison @KacperKluka