Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Ably wrapper to fail early when trying to call a method while the required channel is not created #496

Open
KacperKluka opened this issue Nov 3, 2021 · 1 comment
Labels
code-quality Affects the developer experience when working in our codebase.

Comments

@KacperKluka
Copy link
Contributor

KacperKluka commented Nov 3, 2021

As noticed here, we have a few methods in the Ably wrapper that accept a callback and need an already created channel (e.g. sendEnhancedLocations()). Currently, if we call those methods while there is no channel created for the given trackable ID, they will do nothing and call the callback with a success. Instead, we would like them to fail early and call the callback with an error.

@KacperKluka KacperKluka added the code-quality Affects the developer experience when working in our codebase. label Nov 3, 2021
@ikbalkaya ikbalkaya linked a pull request Nov 11, 2021 that will close this issue
@ikbalkaya ikbalkaya removed a link to a pull request Nov 11, 2021
@deanna-lad
Copy link

The corresponding Jira issue is https://ably.atlassian.net/browse/SDK-1338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Affects the developer experience when working in our codebase.
Development

No branches or pull requests

2 participants