Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Java-WebSockets security issue #688

Closed
KacperKluka opened this issue Jun 13, 2022 · 1 comment · Fixed by #693
Closed

Fix Java-WebSockets security issue #688

KacperKluka opened this issue Jun 13, 2022 · 1 comment · Fixed by #693
Assignees
@KacperKluka
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@KacperKluka
Copy link
Contributor

KacperKluka commented Jun 13, 2022 •
edited by ably-sync-bot

We've received the below information about the SDK:

In Java-WebSocket less than or equal to 1.4.1, there is an Improper Validation of Certificate with Host Mismatch where WebSocketClient does not perform SSL hostname validation. This has been patched in 1.5.0.

This dependency is used in ably-java, so after ably/ably-java#776 is resolved and a new ably-java SDK version is released we should update the ably-java version in AAT project.

┆Issue is synchronized with this Jira Task by Unito
@KacperKluka KacperKluka added the bug Something isn't working. It's clear that this does need to be fixed. label Jun 13, 2022
@KacperKluka KacperKluka self-assigned this Jun 15, 2022
@QuintinWillison
Copy link
Contributor

This is now ready to work on as ably-android version 1.2.13 has been released.

@KacperKluka KacperKluka linked a pull request Jun 17, 2022 that will close this issue
Update ably-android version to 1.2.14 #693
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KacperKluka KacperKluka

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ably-android version to 1.2.14 ably/ably-asset-tracking-android
2 participants
@QuintinWillison @KacperKluka