Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose device property in ARTRealtime.h #1154

Closed
ben-xD opened this issue Jul 21, 2021 · 1 comment
Closed

Expose device property in ARTRealtime.h #1154

ben-xD opened this issue Jul 21, 2021 · 1 comment
Assignees

Comments

@ben-xD
Copy link
Contributor

ben-xD commented Jul 21, 2021

According to RSH8 in the feature spec, Rest and Realtime should have a device method, but this doesn't exist in e.g. ARTRealtime.h Ably-cocoa. The method is defined in ARTRealtime.m though. To be consistent with ARTRest.h which exposes a property instead of a method, we could expose a property called device in ARTRealtime.h.

In ARTRealtime.m:

#if TARGET_OS_IOS
- (ARTLocalDevice *)device {
    return _internal.device;
}
#endif

We should make device property which provides ARTLocalDevice available from ARTRealtime.

┆Issue is synchronized with this Jira Uncategorised by Unito

@lukasz-szyszkowski lukasz-szyszkowski self-assigned this Jul 21, 2021
@ben-xD
Copy link
Contributor Author

ben-xD commented Jul 21, 2021

Closing because this is already made available by @protocol ARTRealtimeProtocol <NSObject>:

#if TARGET_OS_IOS
@property (readonly) ARTLocalDevice *device;
#endif

@ben-xD ben-xD closed this as completed Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants