Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling state's machine activation callback upon push device details failure #1236

Closed
maratal opened this issue Nov 27, 2021 · 1 comment
Closed

Calling state's machine activation callback upon push device details failure #1236

maratal opened this issue Nov 27, 2021 · 1 comment
Assignees
@maratal
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@maratal
Copy link
Collaborator

maratal commented Nov 27, 2021 •
edited by sync-by-unito bot

In a ARTPushActivationStateWaitingForPushDeviceDetails class the transition to ARTPushActivationStateNotActivated state erroneously calls callActivatedCallback function. It should be callDeactivatedCallback.

┆Issue is synchronized with this Jira Bug by Unito
@maratal maratal self-assigned this Nov 27, 2021
@maratal maratal added the bug Something isn't working. It's clear that this does need to be fixed. label Nov 27, 2021
This was referenced Nov 27, 2021
Closed
Closed
@maratal
Copy link
Collaborator Author

maratal commented Nov 27, 2021

Closing this issue, because turned out it should be callActivatedCallback with error.

@maratal maratal closed this as completed Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maratal maratal

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced call to callActivatedCallback to callDeactivatedCallback ably/ably-cocoa
1 participant
@maratal