Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for invalid state operations #843

Closed
SimonWoolf opened this issue Apr 16, 2019 · 1 comment · Fixed by #895
Closed

Improve error message for invalid state operations #843

SimonWoolf opened this issue Apr 16, 2019 · 1 comment · Fixed by #895
Assignees
Labels
enhancement New feature or improved functionality.

Comments

@SimonWoolf
Copy link
Member

SimonWoolf commented Apr 16, 2019

Currently, a publish when the library is closed, or the channel is detached or failed, all return "channel operation failed (invalid channel state)". This isn't the most helpful when customers complain thhat they're getting that and want to know why -- it could be a bit more specific (because connection is ' + connection.state, 'because channel state is ' + this.state`), and in the case of failed it could perhaps return the stringified errorReason too.

┆Issue is synchronized with this Jira Story by Unito

@SimonWoolf SimonWoolf added the enhancement New feature or improved functionality. label Apr 16, 2019
@maratal maratal linked a pull request Aug 27, 2021 that will close this issue
@maratal maratal closed this as completed Aug 27, 2021
@ably-sync-bot
Copy link

➤ Marat Alekperov commented:

This issue was done shortly after it was reported but somehow remained opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

Successfully merging a pull request may close this issue.

3 participants