Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ably-go doesn't retry requests to fallback hosts on a timeout #626

Closed
mclark-ably opened this issue Jan 11, 2024 · 2 comments · Fixed by #629
Closed

ably-go doesn't retry requests to fallback hosts on a timeout #626

mclark-ably opened this issue Jan 11, 2024 · 2 comments · Fixed by #629
Assignees

Comments

@mclark-ably
Copy link

https://sdk.ably.com/builds/ably/specification/main/features/#RSC15l specifies the the conditions of when an Ably SDK should retry a request to a fallback endpoint.

Specifically https://sdk.ably.com/builds/ably/specification/main/features/#RSC15l2 is not implemented. A request that times out continues to try at the primary endpoint e.g.

[ERROR] RestClient: failed sending a request Post \"https://rest.ably.io:443/keys/<Ably_key_name>/requestToken\": context deadline exceeded"}

Copy link

sync-by-unito bot commented Jan 11, 2024

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-4024

@sacOO7
Copy link
Collaborator

sacOO7 commented Jan 19, 2024

This also needs to be refactored based on one of the old fallbacks PR
https://github.com/ably/ably-go/pull/316/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants