Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL2c #241

Merged
merged 1 commit into from Feb 24, 2016
Merged

RTL2c #241

merged 1 commit into from Feb 24, 2016

Conversation

ricardopereira
Copy link
Contributor

No description provided.

@tcard
Copy link
Contributor

tcard commented Feb 23, 2016

The spec also says that the error should be emitted. I guess you can just add an on that checks that the error emitted is the same that errorReason.

@ricardopereira
Copy link
Contributor Author

The spec also says that the error should be emitted. I guess you can just add an on that checks that the error emitted is the same that errorReason.

Done 14d53e7.
Thanks.

@tcard
Copy link
Contributor

tcard commented Feb 23, 2016

LGTM

ricardopereira added a commit that referenced this pull request Feb 24, 2016
@ricardopereira
Merge pull request #241 from ably/RTL2c
9c7bc2c 
RTL2c
@ricardopereira ricardopereira merged commit 9c7bc2c into master Feb 24, 2016
@ricardopereira ricardopereira deleted the RTL2c branch February 24, 2016 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ricardopereira @tcard