Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTN17b as a part of 0.9 #502

Merged
merged 1 commit into from Sep 21, 2016
Merged

RTN17b as a part of 0.9 #502

merged 1 commit into from Sep 21, 2016

Conversation

EvgenyKarkan
Copy link
Contributor

Please review and merge if everything looks good.

mattheworiordan
mattheworiordan approved these changes Sep 16, 2016
View reviewed changes
Copy link
Member

@mattheworiordan mattheworiordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think you have coverage for the reverse situation i.e. only use fallbacks when default host endpoint used by default.

@EvgenyKarkan
Copy link
Contributor Author

Yes, there is already a test for that case.

@tcard tcard changed the base branch from RSC15b to master September 21, 2016 14:54
@tcard tcard merged commit 122a218 into master Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattheworiordan mattheworiordan mattheworiordan approved these changes

@tcard tcard tcard approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EvgenyKarkan @mattheworiordan @tcard