Fix memory consumption bug #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source/ARTLog.m
Outdated
| @@ -109,7 +109,7 @@ - (instancetype)init { | |||
| } | |||
|
|
|||
| - (instancetype)initCapturingOutput:(BOOL)capturing { | |||
| return [self initCapturingOutput:true historyLines:100]; | |||
| return [self initCapturingOutput:true historyLines:50]; | |||
There was a problem hiding this comment.
The history is sent to Sentry when an exception occurs. I think 50 is too low. 100 lines would give us more elements to diagnose an issue. Does this change improve significantly the performance?
There was a problem hiding this comment.
Will measure and let you know.
ricardopereira
approved these changes
Mar 14, 2018
|
Tests aren't passing: |
|
@ricardopereira I did some profiling.
|
funkyboy
force-pushed
the
fix-memory-consumption-bug
branch
from
647791b
to
02c022f
Compare
|
@funkyboy Ok, thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #691