Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncHttpScheduler.dispose() is never used #523

Closed
amihaiemil opened this issue Nov 15, 2019 · 1 comment
Closed

AsyncHttpScheduler.dispose() is never used #523

amihaiemil opened this issue Nov 15, 2019 · 1 comment

Comments

@amihaiemil
Copy link
Contributor

amihaiemil commented Nov 15, 2019 •
edited by sync-by-unito bot

According to my IDE (IntelliJ), the method AsyncHttpScheduler.dispose() is never called anywhere.

From what I can tell, this was supposed to be some sort of closing/cleanup method. Maybe this class should implement Autocloseable? This is just a guess, we can just as well remove it.

┆Issue is synchronized with this Jira Research by Unito
@QuintinWillison
Copy link
Contributor

This will be cleaned up by the work I am doing under #801.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amihaiemil @QuintinWillison