Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an error code and error message for failed queued messages #920

Closed
ikbalkaya opened this issue Feb 23, 2023 · 1 comment · Fixed by #922
Closed

Provide an error code and error message for failed queued messages #920

ikbalkaya opened this issue Feb 23, 2023 · 1 comment · Fixed by #922
Assignees
@ikbalkaya
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@ikbalkaya
Copy link
Contributor

The code below creates an empty error info when a pending message fails. It must also contain a convenient code and message (check spec and other SDKs)

ably-java/lib/src/main/java/io/ably/lib/transport/ConnectionManager.java

Line 1800 in 94ecb6f

queuedMessage.listener.onError(new ErrorInfo());

@sync-by-unito
Copy link

sync-by-unito bot commented Feb 23, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3418

@ikbalkaya ikbalkaya added the bug Something isn't working. It's clear that this does need to be fixed. label Feb 23, 2023
@ikbalkaya ikbalkaya mentioned this issue Feb 23, 2023
Closed
@ikbalkaya ikbalkaya self-assigned this Feb 24, 2023
@ikbalkaya ikbalkaya mentioned this issue Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikbalkaya ikbalkaya

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add reason to pending message instead of creating an ErrorInfo ably/ably-java
1 participant
@ikbalkaya