equals() for TokenDetails is broken

[ikbalkaya]

Following is how equals has been implemented for TokenDetails

 @Override
   public boolean equals(Object obj) {
            TokenDetails details = (TokenDetails)obj;
            return equalNullableStrings(this.token, details.token) &
                    equalNullableStrings(this.capability, details.capability) &
                    equalNullableStrings(this.clientId, details.clientId) &
                    (this.issued == details.issued) &
                    (this.expires == details.expires);
        }    

This implementation doesn't take into account when obj is null or not the type of token details.

Expected
Return false when obj is null or a different type

Spotted:
Flutter plugin Stream writer does this check when writing types to streams

protected void writeValue(@NonNull ByteArrayOutputStream stream, @Nullable Object value) {
    if (value == null || value.equals(null)) {
      stream.write(NULL);

[sync-by-unito]

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3465