Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider enabling type-checking for modular tests #1703

Open
lawrence-forooghian opened this issue Mar 19, 2024 · 0 comments
Open

Consider enabling type-checking for modular tests #1703

lawrence-forooghian opened this issue Mar 19, 2024 · 0 comments
Labels
code-quality Affects the developer experience when working in our codebase. testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Mar 19, 2024 •
edited by sync-by-unito bot
Loading

Also, since this test suite is an es module istm we should easily be able to enable type checking for development here. Might be different for other editors but in my neovim i can get a type warning for this issue by running cp modular.d.ts build/modular/index.d.ts and adding a // @ts-check comment to the top of modular.test.js.

Originally posted by owenpearson in #1701 (review)

┆Issue is synchronized with this Jira Task by Unito
@lawrence-forooghian lawrence-forooghian mentioned this issue Mar 19, 2024
Merged
@VeskeR VeskeR added code-quality Affects the developer experience when working in our codebase. testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them. labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Affects the developer experience when working in our codebase. testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VeskeR @lawrence-forooghian