Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error messages for missing keys when creating an upload #52

Open
lawrence-forooghian opened this issue May 23, 2022 · 0 comments

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented May 23, 2022

Submitting an upload without github_base_ref / github_head_ref in the body gives a validation error e.g. 'github_base_ref must be a string'. These error messages are slightly misleading - github_base_ref and github_head_ref are nullable (i.e. you have to provide the key, but the value is allowed to be null).

Internal discussion: https://ably-real-time.slack.com/archives/C030C5YLY/p1652438829327409?thread_ts=1652428652.185689&cid=C030C5YLY

┆Issue is synchronized with this Jira Uncategorised by Unito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant