Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't build with dart 2.13 (Flutter 2.2) #42

Closed
tvh opened this issue May 19, 2021 · 9 comments
Closed

Doesn't build with dart 2.13 (Flutter 2.2) #42

tvh opened this issue May 19, 2021 · 9 comments

Comments

@tvh
Copy link

tvh commented May 19, 2021

The following function was removed in dart 2.13 and is used in the jscore-bindings:

@Deprecated('Hold on to the pointer backing a struct instead.')
Pointer<T> get addressOf => _addressOf as Pointer<T>;
@cacard
Copy link

cacard commented May 28, 2021

here is my error when compile on flutter 2.2:

/C:/flutter_windows_2.2.0-stable/flutter/.pub-cache/hosted/pub.flutter-io.cn/flutter_js-0.2.3+0/lib/javascriptcore/jscore/js_class.dart:16:70: Error: The getter 'addressOf' isn't defined for the class 'JSClassDefinition'.

  • 'JSClassDefinition' is from 'package:flutter_js/javascriptcore/binding/js_object_ref.dart' ('/C:/flutter_windows_2.2.0-stable/flutter/.pub-cache/hosted/pub.flutter-io.cn/flutter_js-0.2.3+0/lib/javascriptcore/binding/js_object_ref.dart').
    Try correcting the name to the name of an existing getter, or defining a getter or field named 'addressOf'.
    : this.pointer = JSObjectRef.jSClassCreate(definition.create().addressOf);

@magnusstjarnhildinbooks
Copy link

magnusstjarnhildinbooks commented Jun 3, 2021

https://github.com/xuelongqy/flutter_jscore have updated its code where they removed the methodcall to addressOf @abner

@vinner2606
Copy link

Please fix this issue in library as soon as possible.

@abner
Copy link
Owner

abner commented Jun 8, 2021

fixed on flutter_js 0.5.0+0

@abner abner closed this as completed Jun 8, 2021
@gzlock
Copy link

gzlock commented Jun 9, 2021

🎉
waiting for you release the 0.5.0+0 to repository

@abner
Copy link
Owner

abner commented Jun 11, 2021

waiting for you release the 0.5.0+0 to repository

it was already published to pub.dev, but i added the tag on github also

@tvh
Copy link
Author

tvh commented Jun 11, 2021

it was already published to pub.dev, but i added the tag on github also

The tag doesn't seem to be correct. The pubspec.yaml is at 0.4.0+6.

@gzlock
Copy link

gzlock commented Jun 12, 2021

waiting for you release the 0.5.0+0 to repository

it was already published to pub.dev, but i added the tag on github also

image
The releases was updated from yesterday, but the master branch was updated from 6 may

@landyrev
Copy link

landyrev commented Jul 1, 2021

@abner could you please push fix to the master? Build still failing when you try to install it from github repo

(I'm trying to make a PR, but I can't manage flutter_js being build from sources)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants